Negated scalar condition for matchers #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 84.61% 84.75% +0.14%
==========================================
Files 148 149 +1
Lines 7080 7152 +72
Branches 3271 3301 +30
==========================================
+ Hits 5991 6062 +71
+ Misses 411 409 -2
- Partials 678 681 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-10-02 19:46:12 Comparing candidate commit 1416eae in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Anilm3
force-pushed
the
anilm3/negated_scalar_condition
branch
from
888d062
to
1fe02c2
Compare
Anilm3
force-pushed
the
anilm3/negated_scalar_condition
branch
from
6ee2834
to
d37459d
Compare
Anilm3
force-pushed
the
anilm3/negated_scalar_condition
branch
from
574fc85
to
2944e23
Compare
Anilm3
force-pushed
the
anilm3/negated_scalar_condition
branch
from
2944e23
to
42fc3fb
Compare
cataphract
reviewed
Sep 26, 2024
cataphract
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to negate certain operators, using the
!as a prefix. The set of operators supported are the following:!match_regex,!phrase_match,!exact_match,!ip_matchand!equals. Negated operators work through the use of thescalar_negated_condition, which operates in a similar manner to thescalar_condition, however only producing a match if the exhaustive evaluation of the given address + key_path results in no match.Negated operators have the following restrictions:
lower_thanandgreater_than, as their negated version can be an operator in and of itself, e.g.greater_equalandlower_equal.Remaining work: